Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 chore: drop go 1.16 support & update dependencies #2374

Merged
merged 5 commits into from
Mar 20, 2023
Merged

Conversation

efectn
Copy link
Member

@efectn efectn commented Mar 15, 2023

Description

1.16 is no longer supported by Fasthttp, let's drop it.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@efectn efectn changed the title 🧹 chore: drop go 1.16 support 🧹 chore: drop go 1.16 support & update dependencies Mar 15, 2023
@gaby
Copy link
Member

gaby commented Mar 16, 2023

Go 1.17 is EOL since August 2022, would it make more sense to make the jump to 1.18 as minimum like the contrib/storage middlewares?

https://endoflife.date/go

@@ -71,7 +71,6 @@ func Test_App_Prefork_Master_Process(t *testing.T) {
}

func Test_App_Prefork_Child_Process_Never_Show_Startup_Message(t *testing.T) {
t.Parallel()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely an unrelated change and should be reverted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just try to fix data race on tests

@gaby
Copy link
Member

gaby commented Mar 16, 2023

Go 1.17 is EOL since August 2022, would it make more sense to make the jump to 1.18 as minimum like the contrib/storage middlewares?

https://endoflife.date/go

I also noticed that action/setup-go tags stable as 1.19 and oldstable as 1.18. We can probably add 1.19 to the test suite.

Src: https://github.com/actions/setup-go#using-stableoldstable-aliases

@ReneWerner87
Copy link
Member

ReneWerner87 commented Mar 16, 2023

Go 1.17 is EOL since August 2022, would it make more sense to make the jump to 1.18 as minimum like the contrib/storage middlewares?

https://endoflife.date/go

we always support the latest version which supports fasthttp, in the new version of fiber we already make this jump

@ReneWerner87 ReneWerner87 merged commit 9064eb6 into master Mar 20, 2023
@efectn efectn deleted the drop-1.16 branch March 20, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants