-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 chore: drop go 1.16 support & update dependencies #2374
Conversation
Go |
@@ -71,7 +71,6 @@ func Test_App_Prefork_Master_Process(t *testing.T) { | |||
} | |||
|
|||
func Test_App_Prefork_Child_Process_Never_Show_Startup_Message(t *testing.T) { | |||
t.Parallel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is most likely an unrelated change and should be reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just try to fix data race on tests
I also noticed that action/setup-go tags stable as 1.19 and oldstable as 1.18. We can probably add 1.19 to the test suite. Src: https://github.com/actions/setup-go#using-stableoldstable-aliases |
we always support the latest version which supports fasthttp, in the new version of fiber we already make this jump |
Description
1.16 is no longer supported by Fasthttp, let's drop it.
Type of change
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/