Optimize basicauth allocations

[msaf1980]

Description

Fix for test basic header as described in RFC 7617, like

Authorization: Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ==

Also avoid string buffer alloc in strings.ToLower if string not in lower case, like Basic

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

[welcome]

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[efectn]

Can you post benchmark results here (old, new)

[msaf1980]

Before (current master)

$ go test -benchmem -run=^$ -bench ^Benchmark_Middleware_BasicAuth github.com/gofiber/fiber/v2/middleware/basicauth
goos: linux
goarch: amd64
pkg: github.com/gofiber/fiber/v2/middleware/basicauth
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Benchmark_Middleware_BasicAuth-6         	 3374157	       356.2 ns/op	      80 B/op	       5 allocs/op
Benchmark_Middleware_BasicAuth_Upper-6   	 3117049	       387.5 ns/op	      80 B/op	       6 allocs/op
PASS
ok  	github.com/gofiber/fiber/v2/middleware/basicauth	3.168s

After (this PR)

$ go test -benchmem -run=^$ -bench ^Benchmark_Middleware_BasicAuth github.com/gofiber/fiber/v2/middleware/basicauth
goos: linux
goarch: amd64
pkg: github.com/gofiber/fiber/v2/middleware/basicauth
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Benchmark_Middleware_BasicAuth-6         	 3175054	       371.6 ns/op	      80 B/op	       5 allocs/op
Benchmark_Middleware_BasicAuth_Upper-6   	 3207657	       376.4 ns/op	      80 B/op	       5 allocs/op
PASS
ok  	github.com/gofiber/fiber/v2/middleware/basicauth	3.156s

As I see, if auth header like Authorization: basic QWxhZGRpbjpvcGVuIHNlc2FtZQ== we have some perf drawback.
But if request like Authorization: Basic QWxhZGRpbjpvcGVuIHNlc2FtZQ== (as described in RFC, and most requests is) - we have minus one allocation.

[efectn]

Can you use https://github.com/gofiber/fiber/blob/master/utils/strings.go#L65 and send results again.

(Also utils.ToLower)

[msaf1980]

With utils.EqualFold

$ go test -benchmem -run=^$ -bench ^Benchmark_Middleware_BasicAuth github.com/gofiber/fiber/v2/middleware/basicauth
goos: linux
goarch: amd64
pkg: github.com/gofiber/fiber/v2/middleware/basicauth
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Benchmark_Middleware_BasicAuth-6         	 3487176	       343.3 ns/op	      80 B/op	       5 allocs/op
Benchmark_Middleware_BasicAuth_Upper-6   	 3503778	       348.3 ns/op	      80 B/op	       5 allocs/op

With utils.ToLower

$ go test -benchmem -run=^$ -bench ^Benchmark_Middleware_BasicAuth github.com/gofiber/fiber/v2/middleware/basicauth
goos: linux
goarch: amd64
pkg: github.com/gofiber/fiber/v2/middleware/basicauth
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Benchmark_Middleware_BasicAuth-6         	 3373893	       358.1 ns/op	      80 B/op	       6 allocs/op
Benchmark_Middleware_BasicAuth_Upper-6   	 3374263	       356.8 ns/op	      80 B/op	       6 allocs/op

Update PR for use utils.EqualFold ?

[efectn]

With utils.EqualFold

$ go test -benchmem -run=^$ -bench ^Benchmark_Middleware_BasicAuth github.com/gofiber/fiber/v2/middleware/basicauth
goos: linux
goarch: amd64
pkg: github.com/gofiber/fiber/v2/middleware/basicauth
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Benchmark_Middleware_BasicAuth-6         	 3487176	       343.3 ns/op	      80 B/op	       5 allocs/op
Benchmark_Middleware_BasicAuth_Upper-6   	 3503778	       348.3 ns/op	      80 B/op	       5 allocs/op

With utils.ToLower

$ go test -benchmem -run=^$ -bench ^Benchmark_Middleware_BasicAuth github.com/gofiber/fiber/v2/middleware/basicauth
goos: linux
goarch: amd64
pkg: github.com/gofiber/fiber/v2/middleware/basicauth
cpu: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
Benchmark_Middleware_BasicAuth-6         	 3373893	       358.1 ns/op	      80 B/op	       6 allocs/op
Benchmark_Middleware_BasicAuth_Upper-6   	 3374263	       356.8 ns/op	      80 B/op	       6 allocs/op

Update PR for use utils.EqualFold ?

sure

[msaf1980]

sure

Done. If you plan to merge, may be better squash commit on merge ?

[efectn]

sure

Done. If you plan to merge, may be better squash commit on merge ?

Don't need it. We're already merging squashed commits into the master

[welcome]

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord