Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 update: replace UnsafeBytes util with suggested way #2204

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

efectn
Copy link
Member

@efectn efectn commented Nov 11, 2022

Description

Fixes #2180
This is also 2 ns/op faster than old way.

Type of change

  • Just an update.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • I tried to make my code as fast as possible with as few allocations as possible

Commit formatting:

Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/

@ReneWerner87 ReneWerner87 merged commit e5ae764 into master Nov 13, 2022
@efectn efectn deleted the update-s2b-util branch November 13, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: unsafeString2Bytes may not be future proof
3 participants