This repository has been archived by the owner on Nov 18, 2022. It is now read-only.
Fix address collision between contract and unused EOA #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the integration-test in CI |
jjyr
suggested changes
May 9, 2022
magicalne
force-pushed
the
fix_addr_collision
branch
from
fe76abc to
a5a0b95
Compare
Flouse
changed the title
|
Please note the change godwokenrises/godwoken-scripts#119 (comment) |
magicalne
force-pushed
the
fix_addr_collision
branch
from
d4bade3 to
7d06ee1
Compare
…y setting to zero hash when overwriting
magicalne
force-pushed
the
fix_addr_collision
branch
from
7d06ee1 to
0106330
Compare
Flouse
reviewed
May 12, 2022
Flouse
previously approved these changes
May 13, 2022
|
Please bump the |
Flouse
previously approved these changes
May 15, 2022
jjyr
previously approved these changes
May 16, 2022
zeroqn
previously approved these changes
May 16, 2022
TheWaWaR
reviewed
May 19, 2022
TheWaWaR
reviewed
May 19, 2022
TheWaWaR
approved these changes
May 19, 2022
Flouse
approved these changes
May 20, 2022
Flouse
changed the title
Flouse
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix address collision between EOA account address and contract address created by
create/create2.We can overwrite the mapping if it's an EOA account and the nonce is 0.