Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/jsx code completion #74

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

lewiji
Copy link
Contributor

@lewiji lewiji commented Oct 26, 2020

In response to issue #73, I have made 2 simple QOL changes:

  • updated the README with some simple pointers on how to get JSX code completion working in the TypeScript section.
  • updated misc/package.json to include "types": "godot.d.ts" by default so that JSX completion should work immediately when generating a TypeScript project from the editor.

I think it might also be nice to be able to generate the decorators.ts/js file separately alongside the existing options to generate the declaration file and enumerations file separately, in case someone didn't want to generate a full TypeScript project but did want to use the decorators. However my C++ is very rusty and my attempt at this didn't get very far, apologies :)

Modified the Typescript section to also reference JSX code completion, with instructions on how to add the definitions .ts file to the package.json for JSX code completion support.
@Geequlim
Copy link
Collaborator

Thanks!

@Geequlim Geequlim merged commit 96da5b9 into godotjs:master Nov 10, 2020
@lewiji lewiji deleted the docs/jsx-code-completion branch November 10, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants