Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve pipeline to publish release builds #170

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Oct 5, 2023

Add additional workflow_call to publish build artifacts for releases

@nmerget nmerget marked this pull request as ready for review October 7, 2023 21:36
@nmerget nmerget requested a review from fire October 7, 2023 21:36
@nmerget nmerget marked this pull request as draft October 7, 2023 21:36
@nmerget nmerget marked this pull request as ready for review October 7, 2023 21:39
@fire
Copy link
Collaborator

fire commented Oct 7, 2023

Typical Godot Engine style is to use one commit because it makes code review easy to see, but it is opposite to common practice of showing historical work. Either style is acceptable. The pipeline appears to work. I'll go download the binary and report back.

@fire
Copy link
Collaborator

fire commented Oct 7, 2023

An initial screenshot works.

image

I would merge and work onwards since the cicd passes. I'm sure there'll be more bugs found when interacting with code.

Copy link
Collaborator

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to publish a tag to check if the system works. It's a catch-22.

@nmerget nmerget merged commit e544bca into godotjs:master Oct 9, 2023
14 checks passed
@nmerget nmerget linked an issue Oct 9, 2023 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor repo branches to enable good publish process
2 participants