Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
godot.d.ts
declaration file generated by the editor have syntax errors. These are:The term
push_*/pop
in the documentation terminating multi-line comments due to the*/
token. This is fixed by replacing all*/
with* /
.KeyModifierMask.KEY_MASK_CMD
not having a value due to the doc having "platform-dependent" as a value instead of an integer. This is fixed by adding a manual check for this specific enum to replace the value with the correct one.I'm happy to discuss alternative solutions or any other comments you might have. I also think having unit tests to detect these errors might be helpful, as future changes to the documentations could result in new errors.