Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with newer godot-cpp versions #143

Closed

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Apr 12, 2024

Force the new "disable_exceptions" argument to false (libdatachannel needs exceptions to build).

Fixes #126 EDIT: Doesn't seem quite enough for windows specifically.

@Faless Faless added bug Something isn't working build system An issue that affects the build system. labels Apr 12, 2024
Force the new "disable_exceptions" argument to false (libdatachannel
needs exceptions to build).
@Faless Faless force-pushed the fix/force_enable_exceptions branch from 4957ea9 to 3400e42 Compare April 12, 2024 17:50
@Faless
Copy link
Collaborator Author

Faless commented Apr 12, 2024

Fixes #126

Doesn't seem quite enough for windows specifically, I'll close and re-open with a different scope.

@Faless Faless closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build system An issue that affects the build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build with Godot 4.2-rc1 and MSVC
1 participant