Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Godot primitives for logging, change default log level #141

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Ughuuu
Copy link
Contributor

@Ughuuu Ughuuu commented Mar 22, 2024

For now this logs debugging in editor and warning in export. Also wasnt sure what to call to log in godot 3.5, so it only has 4.0.

@Faless Faless added the enhancement New feature or request label Apr 10, 2024
@Faless
Copy link
Collaborator

Faless commented Apr 10, 2024

Also wasnt sure what to call to log in godot 3.5, so it only has 4.0.

Thank you for your contribution, I've made the changes for 3.5, and switched to print_verbose in 4.x.

Sadly, the server hosting our linux toolchains is offline, so the linux builds are failing.

I'll see if we can setup github mirrors of the toolchains or in any case fix the CI as soon as possible.

@Faless Faless changed the title Logging in godot Use Godot primites for logging, change default log level Apr 12, 2024
@Faless Faless force-pushed the logging-in-godot branch from a0991e4 to 81ebf48 Compare April 12, 2024 12:27
@Faless Faless changed the title Use Godot primites for logging, change default log level Use Godot primitives for logging, change default log level Apr 12, 2024
@Faless Faless force-pushed the logging-in-godot branch from 81ebf48 to e391109 Compare April 12, 2024 13:10
@Faless Faless merged commit 66a9c6b into godotengine:master Apr 12, 2024
13 checks passed
@Faless
Copy link
Collaborator

Faless commented Apr 12, 2024

Thank you for your contribution 🚀 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants