Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Viewport children to lock, group, and insert keyframes #99994

Merged

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Dec 4, 2024

In the 2D Editor, allows lock, unlock, group, ungroup, copy pose, clear pose, and insert keyframe while there is a Viewport ancestor.
In the 3D Editor, allows lock, unlock, group, and ungroup.

@kitbdev kitbdev requested a review from a team as a code owner December 4, 2024 01:05
@kitbdev kitbdev force-pushed the fix-editor-viewport-group-anim branch from 1ec55df to 159d70a Compare December 4, 2024 01:14
@kitbdev kitbdev requested a review from a team as a code owner December 4, 2024 01:14
@AThousandShips AThousandShips added this to the 4.4 milestone Dec 4, 2024
@KoBeWi
Copy link
Member

KoBeWi commented Dec 28, 2024

Like in #99401 (comment), this allows locking nodes outside the current scene, but not insert keyframes. It's also not really a problem though.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why it was disabled in the first place tbh.

@akien-mga akien-mga merged commit 442f114 into godotengine:master Jan 3, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the fix-editor-viewport-group-anim branch January 3, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants