Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependency detection in render graph for draw lists with partial coverage. #99426

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

DarioSamo
Copy link
Contributor

Fixes #99228.

This makes a couple of improvements to the logic used to detect command dependencies to help the new draw list partial coverage detection.

  • Layout transitions should not be considered as partial coverage, as they affect the entire resource.
  • Texture size is now embedded in the tracker, and partial coverage is just considered to be used if the draw list doesn't completely cover the texture.
  • Write list nodes now embed whether partial coverage was in use when the node was added, to skip intersection detection that can lead to false positives.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Repiteo Repiteo merged commit 480f616 into godotengine:master Nov 19, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 19, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D shadow issues with multiple viewports and particles with enabled SDF collision
4 participants