Cleanup and expose FileAccessMemory.
#98287
Open
+141
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
reviewed
Oct 21, 2024
|
|
||
| class FileAccessMemory : public FileAccess { | ||
| struct FileInfo { | ||
| PackedByteArray data; |
There was a problem hiding this comment.
Could we expand this struct to also represent uint8_t *data so we can combine and simplify the implementation?
1 task
17 tasks
Would be nice to have this sooner than later in a separate PR, since it sounds like an objective improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
FileAccessMemoryasmem://filesystem, and cleans up previously unused mem file registration (changed for permanent list to ref. counted).Fixes godotengine/godot-proposals#10978 (note: I think there was an older proposal to expose it as well, but I can't find it)