Add filter & sort to editor file dialog #97344
Merged
+314
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
reviewed
Sep 25, 2024
pafuent
force-pushed
the
editor_file_dialog_filter_sort
branch
from
3668ed2 to
d8cb252
Compare
pafuent
force-pushed
the
editor_file_dialog_filter_sort
branch
from
d8cb252 to
8ead241
Compare
Geometror
approved these changes
Sep 26, 2024
AThousandShips
approved these changes
Sep 26, 2024
akien-mga
reviewed
Sep 26, 2024
pafuent
force-pushed
the
editor_file_dialog_filter_sort
branch
from
8ead241 to
f037ee5
Compare
akien-mga
reviewed
Sep 26, 2024
Closes godotengine/godot-proposals#2721 On `EditorFileDialog`: * Add filter box that only shows folders and files in current directory that match * Add sort button to sort files and directories * Add a shortcut for CTRL+F for selecting the filter box Also moved common code between `EditorFileDialog` and `FileSystemDock` to it's own file. Co-authored-by: fox <[email protected]>
pafuent
force-pushed
the
editor_file_dialog_filter_sort
branch
from
f037ee5 to
1637539
Compare
akien-mga
approved these changes
Sep 26, 2024
|
Thanks! |
|
@pafuent Hey! thank you for fixing up and getting this PR merged! glad to see this added :D |
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#2721
On
EditorFileDialog:Also moved common code between
EditorFileDialogandFileSystemDockto it's own file.This tries to address comments on #48734 and change it to make it compatible with code on
master.