Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metal: expose MTLDevice #97309

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Metal: expose MTLDevice #97309

merged 1 commit into from
Oct 7, 2024

Conversation

kroketio
Copy link
Contributor

@kroketio kroketio commented Sep 22, 2024 •
edited
Loading

expose MTLDevice

The equivalent over at Vulkan is

godot/drivers/vulkan/rendering_device_driver_vulkan.cpp

Lines 5184 to 5188 in e4e024a

uint64_t RenderingDeviceDriverVulkan::get_resource_native_handle(DriverResource p_type, ID p_driver_id) {
switch (p_type) {
case DRIVER_RESOURCE_LOGICAL_DEVICE: {
return (uint64_t)vk_device;
}

loosely related to #97304

@AThousandShips AThousandShips requested a review from a team September 22, 2024 09:52
@AThousandShips AThousandShips added this to the 4.x milestone Sep 22, 2024
stuartcarnie
stuartcarnie approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – thanks!

adamscott
adamscott approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartcarnie approved.

@adamscott adamscott modified the milestones: 4.x, 4.4 Oct 7, 2024
@adamscott adamscott requested a review from clayjohn October 7, 2024 13:38
@clayjohn clayjohn merged commit e7c39ef into godotengine:master Oct 7, 2024
19 checks passed
@clayjohn
Copy link
Member

clayjohn commented Oct 7, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@stuartcarnie stuartcarnie stuartcarnie approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
enhancement topic:rendering
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@kroketio @clayjohn @stuartcarnie @adamscott @AThousandShips