thorvg: Update to 0.14.9 #96658
Merged
thorvg: Update to 0.14.9 #96658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:thirdparty
cherrypick:4.3
fire
reviewed
Sep 6, 2024
There was a problem hiding this comment.
I'll try the test cases from @antimundo #96491 as a basic check.
- The pr is a good bug fix from a conceptual point of view
- Technical review was done upstream and doesn't modify godot engine code
- Since it doesn't modify godot engine code, we'll defer to upstream style review
- Needs to follow a test plan of loading the test cases and checking if it's ok. There's the test Godot Engine project from @antimundo and the Omigroup logo from @aaronfranke
fire
approved these changes
Sep 6, 2024
|
Here is a fix for bug that "Update to 0.14.9" introduces ;) |
Fixes godotengine#96491. Update fix for godotengine#96262 to a simple revert of the problematic commit, as the upstream fix is still being debated and caused other issues. Also include fix for upstream regression 2715 added in 0.14.9.
akien-mga
force-pushed
the
thorvg-0.14.9
branch
from
e4b5dfa to
a6ab039
Compare
Thanks, added. |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fix for #96262 to a simple revert of the problematic commit, as the upstream fix is still being debated and caused other issues.
Also include fix for upstream regression 2715 added in 0.14.9.