Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextEdit] Add support for using SyntaxHighlighter for BiDi override and font override. #96588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 5, 2024

Screenshot 2024-09-05 at 07 57 47

@bruvzg bruvzg added this to the 4.x milestone Sep 5, 2024
@bruvzg bruvzg force-pushed the gds_hl_stt branch 2 times, most recently from d50e916 to 7531159 Compare September 6, 2024 11:39
editor/editor_settings.cpp Outdated Show resolved Hide resolved
@bruvzg bruvzg force-pushed the gds_hl_stt branch 2 times, most recently from 7994cb6 to 03cd2bd Compare September 9, 2024 07:14
@bruvzg bruvzg changed the title [WIP, TextEdit] Add support for using SyntaxHighligther for BiDi override and font override. [TextEdit] Add support for using SyntaxHighligther for BiDi override and font override. Oct 7, 2024
@bruvzg bruvzg marked this pull request as ready for review October 7, 2024 06:57
@bruvzg bruvzg requested review from a team as code owners October 7, 2024 06:57
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of these are my mind going "while we are at it".

doc/classes/CodeHighlighter.xml Outdated Show resolved Hide resolved
doc/classes/CodeHighlighter.xml Outdated Show resolved Hide resolved
doc/classes/CodeHighlighter.xml Outdated Show resolved Hide resolved
doc/classes/CodeHighlighter.xml Outdated Show resolved Hide resolved
doc/classes/CodeHighlighter.xml Outdated Show resolved Hide resolved
doc/classes/TextEdit.xml Outdated Show resolved Hide resolved
doc/classes/TextEdit.xml Outdated Show resolved Hide resolved
<return type="String" />
<param index="0" name="line" type="int" />
<description>
Returns line text including current IME preedit string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am... a bit confused on what this is, description doesn't help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preedit string is pretty standard terminology for IME. It's part of the text which is currently edited (controlled by IME driver), but it's not part of the text property until the edit is committed. So this function returns text which is currently displayed.

doc/classes/EditorSettings.xml Outdated Show resolved Hide resolved
doc/classes/EditorSettings.xml Outdated Show resolved Hide resolved
@bruvzg bruvzg requested review from a team as code owners December 4, 2024 14:48
@fire fire changed the title [TextEdit] Add support for using SyntaxHighligther for BiDi override and font override. [TextEdit] Add support for using SyntaxHighlighter for BiDi override and font override. Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants