-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextEdit] Add support for using SyntaxHighlighter for BiDi override and font override. #96588
base: master
Are you sure you want to change the base?
Conversation
d50e916
to
7531159
Compare
7994cb6
to
03cd2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these are my mind going "while we are at it".
doc/classes/TextEdit.xml
Outdated
<return type="String" /> | ||
<param index="0" name="line" type="int" /> | ||
<description> | ||
Returns line text including current IME preedit string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am... a bit confused on what this is, description doesn't help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preedit string
is pretty standard terminology for IME. It's part of the text which is currently edited (controlled by IME driver), but it's not part of the text
property until the edit is committed. So this function returns text which is currently displayed.
…and font override.
Related proposal - Script Editor: Add RTL (Right to Left) support godot-proposals#10629
Related proposal - Implement using several different font styles (light, bold, italic, …) and colors in one single TextEdit godot-proposals#1781