Improvements and fixes for the default theme. #9652
Conversation
|
here's for comparison with flat. |
|
@reduz, flat design is, maybe, a good thing, but don't go too far with it. Tabs, in my humble opinion, need to be highlighted in one way, or another. This way we clearly see, that it is actually the widget. |
|
@Iniquitatis tab highlighting is unrelated to flat design. I can't think of any UI that highlights the tabs this way instead of making them part of the panel. It just feels wrong. |
djrm
force-pushed
the
theme_fixes
branch
3 times, most recently
from
0cc3f9b to
69a308b
Compare
|
Would it be possible to only add a light border to the tabs instead of highlighting all of it? A simple underline might even do the trick, but this amount of highlight is visually gruesome. |
|
Ty soo much for the grid colour change! |
|
Overall I like the change, but I'd mostly side with @reduz on those two points:
|
|
I also agree that tabs highlighting is overkill and looks old. Overall looks awesome! :D |
|
thats why the first screenshot reflects how the theme looks on default settings the rest of the settings are examples with different settings like highlight_tabs, and border size = 0. of course thats up to you to decide which one you like best, but THE DEFAULT is like the first screenshot ONLY. |
|
I understand, and I don't like the thick borders of the DEFAULT :) |
|
@akien-mga do you mean the current default or my proposed default, just to clarify, because if its the later i dont see thick borders at all. this is my proposed default |
|
oh, since i read all this on the mail, i did no realize you edited the original post. |
|
@reduz yeah, i think thats the problem with editing the PR. well at least everything is now clarified. |
|
@djrm Well this looks pretty thick to me: |
|
@akien-mga oh you mean that, yeah, well, the only place where that looks bad is in the viewport, in all other case its better, since the editor does not have the correct spacing, in all elements and that makes it look really bad, so i think i should just add a style override for the viewport |
|
I don't think it looks bad currently, I like the 1px border, more is unnecessary IMO (especially since we already have a lot of space between containers). |
|
@djrm I agree that the no border viewport looks better. |
|
yeah, i will change that on my next PR, it will look like this, no it has proper borders when needed, so things dont look that close to each other.
|
Added customizable border size and window highlight.
|
About the 1px "borders | margins", i know some people prefer the no margins options but you have to think about the engine visual consistency and quality vs a <20px space saving or a "better" looking panels, if you put 1px margins, then the interface looks really cheap (that can be solved by adding proper internal margins) but thats more work and then we will have the same space just in other places, so please think about the quality, i've never seen a decent site or interface that has those issues, and i really sugest that we take that into consideration, so for me is not about a personal visual preference, is about the visual quality of the engine. I've changed most of the request, because they do not interfere with the quality, but rather what most people find more apealing, but in this particular case i think its a really bad idea to change to 1px. examples:
|
|
I also think that current state of editor widgets where they are touching borders looks horrible and cheap. State of spacing in editor must be fixed badly :< I want to help with that, but currently I'm crunching at work. :< Other things would be stronger colors for VS and XYZ so they wont get lost visually. Did I mentioned I love your default sky gradient xD? |
|
I totally see the issue with no border in the visual script editor and many other places. That ui elements are just too close to the edge of the dock and it looks awkward. Especially if they have a border on the left but none on the right.
|
|
Testing. It looks much better in general, here's some feedback
1) Separators in Menus, as well as H/V Separators. We need them to exist
and be visible, so users know they can use them
2) I honestly think the black outlines against Tree and ItemList don't look
very good. At least after coming from the previous theme, they feel like a
downgrade. disabling them makes it cleaner imo.
3) The bigger margins definitely are better, agreed on that.
[image: Inline image 2]
…On Mon, Jul 17, 2017 at 5:36 PM, Rémi Verschelde ***@***.***> wrote:
Merged #9652 <#9652>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9652 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AF-Z24uey6veRZ3JwMNMNF9JL2Fq5ZOpks5sO8XCgaJpZM4OY6mm>
.
|
|
guess attaching image from email did not work, attaching here |
|
Actually nevermind, when there is content in the boxes, the dark lines help a lot. I take back comment #2. |
|
Also, customizing colors from the project settings is not working.. did you test this function? |
|
nevermind again, it's working |
Added missing textures, polished some elements, and created a more consistent look
this is how it looks on default
you can customize it look this way
or this way
