Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add NotNullWhenAttribute to IsInstanceValid #95431

Merged
merged 1 commit into from
Aug 16, 2024
Merged

C#: Add NotNullWhenAttribute to IsInstanceValid #95431

merged 1 commit into from
Aug 16, 2024

Conversation

Joy-less
Copy link
Contributor

Fixes #10418

@Joy-less Joy-less requested a review from a team as a code owner August 12, 2024 15:45
@raulsntos raulsntos added enhancement topic:dotnet cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 12, 2024
@raulsntos raulsntos added this to the 4.4 milestone Aug 12, 2024
raulsntos
raulsntos approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing to the .NET module!

@akien-mga akien-mga changed the title Add NotNullWhenAttribute to IsInstanceValid C#: Add NotNullWhenAttribute to IsInstanceValid Aug 16, 2024
@akien-mga akien-mga merged commit c98d549 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Joy-less Joy-less deleted the Fix-#10418 branch August 16, 2024 13:07
@jss2a98aj jss2a98aj mentioned this pull request Oct 19, 2024
Merged
@Spartan322 Spartan322 mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release enhancement topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Joy-less @akien-mga @raulsntos