Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Optimize Mesh import option from OBJ mesh import #94100

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 8, 2024

This option was enabled by default, but it did nothing regardless of whether it was enabled or not.

@Calinou Calinou requested a review from a team as a code owner July 8, 2024 20:57
@Calinou Calinou added this to the 4.x milestone Jul 8, 2024
This option was enabled by default, but it did nothing regardless
of whether it was enabled or not.
@Calinou Calinou force-pushed the obj-import-remove-unused-optimize-mesh branch from 085ea99 to 5ee4100 Compare July 8, 2024 20:58
@Calinou Calinou requested a review from a team as a code owner July 8, 2024 20:58
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of weird future-proofing like Godot 3.x's LOD parameters genuinely grinds my gears.

@lyuma
Copy link
Contributor

lyuma commented Jul 8, 2024

Would it not make sense to fix the option by calling generate_lods? I assume that was the intent behind this checkbox.

@fire
Copy link
Member

fire commented Jul 8, 2024

I expect that the fix would be to call generate_lods.

Edited:

The correct generate lod is from importer mesh and not the other one from surface tool.

@Calinou
Copy link
Member Author

Calinou commented Jul 8, 2024

Would it not make sense to fix the option by calling generate_lods? I assume that was the intent behind this checkbox.

The intent of this checkbox was likely to replicate 3.x functionality, where you could choose between several kinds of per-vertex data to compress (vertex, normal, tangent, UV, …). There was no LOD back then.

Edit: I've opened a PR to add that option specifically: #94108

I expect that the fix would be to call generate_lods.

That would be a different option which would be called generate_lods 🙂

See godotengine/godot-proposals#5600.

@akien-mga akien-mga merged commit e52cf86 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants