-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused Optimize Mesh import option from OBJ mesh import #94100
Remove unused Optimize Mesh import option from OBJ mesh import #94100
Conversation
This option was enabled by default, but it did nothing regardless of whether it was enabled or not.
085ea99
to
5ee4100
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of weird future-proofing like Godot 3.x's LOD parameters genuinely grinds my gears.
Would it not make sense to fix the option by calling generate_lods? I assume that was the intent behind this checkbox. |
I expect that the fix would be to call generate_lods. Edited: The correct generate lod is from importer mesh and not the other one from surface tool. |
The intent of this checkbox was likely to replicate 3.x functionality, where you could choose between several kinds of per-vertex data to compress (vertex, normal, tangent, UV, …). There was no LOD back then. Edit: I've opened a PR to add that option specifically: #94108
That would be a different option which would be called |
Thanks! |
This option was enabled by default, but it did nothing regardless of whether it was enabled or not.