Fix TabContainer regressions related to switching tabs in certain cases
#91188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
reviewed
Apr 26, 2024
YeldhamDev
force-pushed
the
love_fixing_other_peoples_regressions
branch
from
23454fc to
1c32fa2
Compare
You should unlink the issue then. I tested and the visibility problem is not fixed. |
|
We could make the tab visibility callback only apply in the editor when it is part of the edited scene, since that is where it is most intended for. Also, the reason it used |
Wait, I just forgot to update the PR's description, because both issues are fixed on my end. What happens in the visibility test scene on your end? |
|
Nevermind, I didn't test properly. |
KoBeWi
approved these changes
May 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91135.
Fix regression caused by Save current tab in
TabBarandTabContainer#83893, where setting the current tab right after entering the tree would make the value be reset to 0.The other one is bit more complicated (caused by Allow no tabs to be selected in TabBar and TabContainer #87194). It happens because the tab visibility change is also triggered if it becomes visible in the tree (even if it was already set to
visible),and I'm not sure how to fix this without some ugly hackiness.Alright, did the cleanest attempt I could, suggestions are welcomed.Thanks to @jsjtxietian for pointing me in the right direction and saving me time.