Add Open Dock shortcuts #90226
Add Open Dock shortcuts #90226
Conversation
|
@kitbdev Could you look into rebasing and resolving merge conflicts so I can review this? |
kitbdev
force-pushed
the
dock-shortcuts
branch
from
a395178 to
dffa4d8
Compare
|
Rebased and fixed merge conflicts. |
| @@ -907,7 +907,7 @@ void VersionControlEditorPlugin::fetch_available_vcs_plugin_names() { | |||
| } | |||
|
|
|||
| void VersionControlEditorPlugin::register_editor() { | |||
| EditorDockManager::get_singleton()->add_dock(version_commit_dock, "", EditorDockManager::DOCK_SLOT_RIGHT_UL); | |||
| EditorDockManager::get_singleton()->add_dock(version_commit_dock, "", EditorDockManager::DOCK_SLOT_RIGHT_UL, ED_SHORTCUT_AND_COMMAND("docks/open_version_control", TTR("Open Version Control Dock"))); | |||
There was a problem hiding this comment.
This shortcut does not appear anywhere, I assume unless you have VCS plugin installed.
There was a problem hiding this comment.
Yes, the VCS plugin is needed for this to show, just like the toggle_version_control_bottom_panel shortcut below.
|
I noticed FileSystem Dock already has a shortcut, but its named differently. Should we make it consistent? 🤔 |
|
We probably should change the Filesystem one to match the other docks, but then the shortcut name won't match when it is at the Bottom Panel. I'm not sure how to fix it besides having 2 separate shortcuts. |
|
IMO FileSystem dock is still a "dock" even if it's at the bottom. Side dock is its default state. |
kitbdev
force-pushed
the
dock-shortcuts
branch
from
dffa4d8 to
e3679b3
Compare
kitbdev
force-pushed
the
dock-shortcuts
branch
from
e3679b3 to
b9f5d0f
Compare
|
Changed it to be with the other docks. |
Allows the user to bind a shortcut to open and focus on the side docks.
Didn't set any defaults, but I can if wanted.
The tab of the dock will be selected, you can use
ui_focus_next(Tab) to go to other focusable parts of the dock that you want.Available as commands in the command palette.
Also updated the EditorPlugin
add_control_to_dockdocumentation and removed the part about bottom panel since users can not use this to make docks that can go to the bottom panel (Unless I'm missing something?).The Filesystem shortcut already exists under Bottom Panels.