-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to omit redundant data for additional packs #89928
base: master
Are you sure you want to change the base?
Conversation
Seems like a good quick fix. I do think at a minimum something like support for |
This comment has been minimized.
This comment has been minimized.
e076df4
to
75517e1
Compare
This comment has been minimized.
This comment has been minimized.
75517e1
to
9439fa0
Compare
This comment has been minimized.
This comment has been minimized.
9439fa0
to
7e7447b
Compare
Co-authored-by: David Nikdel <[email protected]>
7e7447b
to
26252eb
Compare
This now apparently ended up having quite a lot of overlap with #64712, which I was just made aware of, which to me looks like a much better approach to achieve this kind of "pack trimming". |
I like the idea of being able to create patches easily because it's a common pattern but patching doesn't really cover the use case of DLC where you're not necessarily diffing anything you're just trying to split the contents into multiple pck files so they are independent. In theory those could also want to be diffs so it feels like it might be orthogonal. That said I think holistically it might make more sense to enumerate all the PCKs as part of the export config (so they could all be generated at once) but that'd be a bigger rethink of the workflow here. |
Hm, yeah, fair point. I do feel like the UX of having both of these options sitting side-by-side is bound to be confusing though. Something as simple as just renaming the option/argument in #64712 to be "Export as Additional Pack" and That way you could just not have any packs listed under "Patches" if you don't want to do any diffing, which seems to work just fine with that PR, as far as I can tell. |
True that would be pretty clean imho. Diffing against nothing should be allowed and putting anything in that list should trigger a diff (they don't need a checkbox really). Then the checkbox remains the main vs aux pack switch you added. |
(Note that this PR has gone through a couple of iterations now, in case some of the conversation here doesn't quite line up.)
This reintroduces the trimming of packs introduced by #82084, which was later reverted in #90476.
This is now instead opt-in and toggled through a checkbox in the "Export PCK/ZIP" file dialog, titled "Export As Additional Pack", similar to the existing "Export With Debug" checkbox. This new checkbox is disabled/unchecked by default.
This PR also exposes a new command-line flag called
--export-additional-pack <preset> <path>
, which functions in much the same way as--export-pack <preset> <path>
except it enables the same trimming as this new file dialog checkbox.Documentation changes can be found in godotengine/godot-docs#9147.
TODO