implemented grow(left,top,right,bottom) function

[toger5]

this function is useful when resizing a rect with different values for each corner.
I need it for the new rounded corner style box implementation.

since it is not directly related with the style box, it might be nicer to have a separated pr...

[bojidar-bg]

Mind if you bind it to GDScript?

Also, not sure if we should have a grow_margin(int(MARGIN_*) margin, real_t amount), WDYT?

[toger5]

grow margin also would be nice!
I think those it's really convenient to have those kind of rect conversions.
should I overload the function or use different names:

.grow(real_t amount)
.grow(left,top,right,bottom)
.grow(Margin:margin, real_t amount)

OR

.grow(real_t amount)
.grow_individual(left,top,right,bottom) //that sounds stupid...
.grow_margin(Margin:margin, real_t amount)

[akien-mga]

I think overloaded functions look better. For the second one, it would likely be better to use the same convention as in CSS (top, right, bottom left), unless there's already a precedent in Godot's API for starting with left.

[toger5]

order was inspired by margin:

enum Margin {

	MARGIN_LEFT,
	MARGIN_TOP,
	MARGIN_RIGHT,
	MARGIN_BOTTOM
};

okay sounds good. (overloading)
I won't do the bindings today (5am...) and the additional (margin,amount) function
where would I find them. (They are not in the Rect2 class)

[akien-mga]

Ok, you can keep the same order as in the enum then, it makes sense.

[bojidar-bg]

I'm not sure if we can bind the overloaded methods properly though...

[toger5]

I'm currently trying... could not compile yet...
If I can't bind overloaded funcs, what naming convention?

grow_margin
grow
grow_expand(left, top,right,bottom) / grow_individual / grow_all / grow_borders / ...

[toger5]

okay same name is just overwriting the binding -> ony one grow function possible...

[toger5]

@akien-mga @bojidar-bg the requested updates are done.

[toger5]

@akien-mga merge ?
or do you want me to rebase before?

[akien-mga]

Would be good if you can squash as the second commit modifies the first commit's implementation. You can take the opportunity to fix the typo in the commit log :p

[toger5]

good call

[toger5]

rebased