-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picks for the 4.2 branch (future 4.2.2) - 2nd batch #87589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit c0a1c5a)
(cherry picked from commit 78e1702)
(cherry picked from commit 453c224)
(cherry picked from commit 7946e84)
Adjust `NOTIFICATION_PREDELETE` in `Node` to clean up owned nodes. Also print a warning, when the owner becomes invalid. (cherry picked from commit d3d00c7)
(cherry picked from commit 34ecfff)
(cherry picked from commit 83992fd)
(cherry picked from commit c0f8e00)
(cherry picked from commit dbcd82b)
…eger and float keyframes. (cherry picked from commit 12ce2e3)
(cherry picked from commit 5f72254)
(cherry picked from commit 397f0b3)
(cherry picked from commit c380b12)
(cherry picked from commit b438e28)
(cherry picked from commit c8fc824)
(cherry picked from commit cb0a37f)
(cherry picked from commit 7a833c9)
(cherry picked from commit 10a8b88)
The feature was added in Godot 4.2, but it goes against recommended best practices for permissions request, as such it's being reverted. In its place, developers now have to explicitly request the permissions they need to access. (cherry picked from commit df4f9e8)
…correctly When the label's `autowrap_mode` is `AUTOWRAP_WORD_SMART` and the initial `text` is set at the same time, it may have a higher height. Set an appropriate minimum size for labels in windows that display incorrectly so that these controls display properly. (cherry picked from commit f932c65)
(cherry picked from commit f8da946)
(cherry picked from commit 0a726d6)
force_draw must be called from main thread (cherry picked from commit b88b84c)
The type of the right operand is now taken into account. (cherry picked from commit 82afe58)
….xml The form should be like { from_port: 0, from_node: "GraphNode name 0", to_port: 1, to_node: "GraphNode name 1" } (cherry picked from commit 53ab38a)
(cherry picked from commit 78c9e2c)
(cherry picked from commit d83cad6)
(cherry picked from commit e7dbb7a)
(cherry picked from commit 361aa90)
(cherry picked from commit d67e7f8)
* Some tests were incorrectly included * SCU builds with animation * Animation `switch` (cherry picked from commit c6a1ae7)
YuriSizov
force-pushed
the
4.2-cherrypicks
branch
from
January 25, 2024 17:55
5af9997
to
881d253
Compare
akien-mga
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a glance.
Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The focus is on crashes, regressions, and bugfixes in general, as well as documentation improvements. There are still more PRs available, but they'll have to wait until 4.2.3.