Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for the 4.2 branch (future 4.2.2) - 2nd batch #87589

Merged
merged 95 commits into from
Jan 25, 2024

Conversation

YuriSizov
Copy link
Contributor

The focus is on crashes, regressions, and bugfixes in general, as well as documentation improvements. There are still more PRs available, but they'll have to wait until 4.2.3.

bruvzg and others added 30 commits January 25, 2024 17:03
Adjust `NOTIFICATION_PREDELETE` in `Node` to clean up owned nodes.
Also print a warning, when the owner becomes invalid.

(cherry picked from commit d3d00c7)
…eger and float keyframes.

(cherry picked from commit 12ce2e3)
The feature was added in Godot 4.2, but it goes against recommended best practices for permissions request, as such it's being reverted.
In its place, developers now have to explicitly request the permissions they need to access.

(cherry picked from commit df4f9e8)
…correctly

When the label's `autowrap_mode` is `AUTOWRAP_WORD_SMART` and the initial `text`
is set at the same time, it may have a higher height.

Set an appropriate minimum size for labels in windows that display incorrectly
so that these controls display properly.

(cherry picked from commit f932c65)
force_draw must be called from main thread

(cherry picked from commit b88b84c)
The type of the right operand is now taken into account.

(cherry picked from commit 82afe58)
….xml

The form should be like { from_port: 0, from_node: "GraphNode name 0", to_port: 1, to_node: "GraphNode name 1" }

(cherry picked from commit 53ab38a)
(cherry picked from commit d83cad6)
(cherry picked from commit d67e7f8)
@YuriSizov YuriSizov requested review from a team as code owners January 25, 2024 17:50
@AThousandShips
Copy link
Member

AThousandShips commented Jan 25, 2024

Nite that #87114 (b0318cf) depends on both of:

tests/test_main.cpp Outdated Show resolved Hide resolved
* Some tests were incorrectly included
* SCU builds with animation
* Animation `switch`

(cherry picked from commit c6a1ae7)
This differs from `Rect2(i)` and was fixed for those classes in the past

(cherry picked from commit b4191bf)
@YuriSizov YuriSizov requested a review from a team as a code owner January 25, 2024 18:00
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance.

@YuriSizov YuriSizov merged commit 7ecb58d into godotengine:4.2 Jan 25, 2024
15 checks passed
@YuriSizov YuriSizov deleted the 4.2-cherrypicks branch January 25, 2024 19:51
@YuriSizov
Copy link
Contributor Author

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.