Allow to move FileSystem dock to bottom and drag resources across bottom docks

[reduz]

• Allows moving the filesystem dock to the bottom
• Added ability to drag resources across bottom docks

Animation, moving filesystem to the bottom dock:

Drag and Drop across bottom panels:

• Production edit: This partially addresses Unify the editor panel docking system and make it more flexible godot-proposals#1508.

[YeldhamDev]

The "Make Floating" button should be expanded horizontally now, so its size isn't at odds with the new one.

[ElvisVilla]

That is really helpful for those that like the horizontal File System, in my case what i would love to have is the vertical panel but the feature to collapse it. That would be increidibly helpful to have more space whenever i need it.

My work around is the NV addon just cuz i can collapse the file system to the bottom and hide it presing the tab, but i would love to be able to just collapse without send it to the bottom :)

The other way is to make floating and minimize. But you know, is not the same :(

[KoBeWi]

Moving the dock breaks icons:

godot.windows.editor.dev.x86_64_nM8NUbxVtF.mp4

The minimum size is very small. This is relevant when your bottom dock is at minimum size. After moving file dock to bottom, it's awkwardly small:

The layout of elements needs some tweaking:

File path and filter do not need to be that big and the icons are misaligned. I'd just put every button/text field in the same row, there is enough space for that. The layout from the side dock does not look that good at the bottom.

Also any reason why Make Floating button does not appear when dock is at the bottom?

[viksl]

1. Regarding the minimum size if it's only for when it's first time dropepd to the bottom then I think it's ok to make it a bit larger but I wouldn't set absolute minimum size so the dock couldn't be minimized below that since this will often be opened while working with the viewport I can already imagine people just quickly dropping the size down while they work and pulling it up when needed (many people do this in Blender with animaiton and pretty much any separated views it's quick and reasonably comfortable to do so when you need more space). I understand you can make it go all away but that will unnecessarily inconvenient people.
   (though if point 3 happened then I'd say min size hardcoded is just fine :-))

2. Overal I like this, it makes sense since FS needs to be accessible with pretty much every dock at the same time so this will allow people to streamline their workflow, love it.

3. One more thing I'd like to see is a hide/show shortcut especially now since this (naturally) reduces the viewport size would it be possible to add a customizable shortcut for people (which as default could even be left empty) to show/hide the FS dock when it's at the bottom panel? Some practical examples for this would be Unreal Engine where I believe it's control + spacebar (or something like that) and it really seems very useful.

4. The icons at least the red one in the corner for how the FS should appear (list vs icons) if clicked on will get the icons back properly btw.

[reduz]

@KoBeWi

Also any reason why Make Floating button does not appear when dock is at the bottom?

It seems when something floats, it still belongs to one of the side docks (as in, it returns when you close it to the position it was before), so making something from the bottom dock float would not have any reference to that. It would need to be something separate to make the bottom docks float eventually, hence out of the scope of this PR.

[PLyczkowski]

IMO each band-aid like this, while lovely for current users, decreases editor intuitiveness for new users, which in this case would expect to relocate tabs via tab dragging, both between areas and between windows, and the long term goal should be aiming for a flexible tabbed approach. Relevant proposals godotengine/godot-proposals#7233 godotengine/godot-proposals#1508 godotengine/godot-proposals#28

[reduz]

@PLyczkowski To you it may be a band aid, but I look at it different:

• For us contributors it keeps the code manageable because it is not a lot. If everything was super flexible as you suggest, it would be considerably more and more complex code.
• If this flexibility is not really needed, then it is better to just allow what has specific demand, rather than go for a very flexible solution. This, again, keeps everything manageable and easy to use. Flexibility has to be justified.

[reduz]

Just to clarify, detaching bottom panels may happen at some point in the future, but there is not nearly as much demand, so it's on low priority. This in exchange had a huge amount of demand.

[jcostello]

What about a key bind to toogle on and off the file system dock?

[reduz]

@jcostello I suggest opening a proposal for this that explains how it would work with the proper context. I am not very famliar with that area (how keyboard shortcuts are organized), and you can get better feedback from other people.

[reduz]

Okay I updated this pull request with the issues mentioned above fixed. I also did a bit of an extra effort to allow other docks to be moved to horizontal position and made the system more generic (though they have to explicitly allow this, only the filesystem one does currently).

I am having trouble figuring out why the icons break, because they don't when the dock is moved to other parts. Maybe someone more familiar with this area can lend a hand.

[YuriSizov]

I would prefer if we implemented this after #84193 is merged. We need to de-bloat EditorNode, not add more code to it.

[reduz]

@YuriSizov That's fair, and the other one looks very nice, what's blocking it?

[YuriSizov]

@reduz Nothing, just wasn't in scope for 4.2 and I didn't get a chance to review it yet. But I will!

[YuriSizov]

I fixed the missing icon issue for you. The theming code in the FS dock was a mess. Also added missing docs, which failed the CI.

[reduz]

@KoBeWi Okay, it looks the problem is because the order can change of bottom panel items and the signal is being connected by item index. I changed the code to simply use the pointer, so it seems to work fine now.

I will clean up the rest of the things you mentioned and hopefully this should be ready to go.

[reduz]

Allright, all changes done, please give a final check and feel free to approve if you believe nothing else remains to be done.

[KoBeWi]

I left some minor comments., but functionality-wise it's fine now.

[reduz]

Alright, done with the suggested changes.

[YuriSizov]

Rebased after recent changes and also fixed another missing icon bug. Seems like a check was added in #23273 to avoid segfault on exit, but this should already be covered in 4.x where NOTIFICATION_THEME_CHANGED won't be sent on exit.

[YuriSizov]

Looks good, works good! The placement popup needs some rework, but it's a pre-existing problem.

Also we should extract bottom panel logic from EditorNode next, cc @kitbdev 😉

[reduz]

Sounds good! I need to give a pass to all the editors in the bottom panel and make sure they can be undocked and redocked at some point, so at some point we can start thinking how to customize their placement too.

[akien-mga]

Thanks!

[ismailgamedev]

It would be better if it disappears by itself when we open the script. We need to be able to adjust the size of the file icons. Also the panel at the top is unnecessarily wide. It needs to be designed as compact as possible to be functional.

[Zireael07]

@ismailgamedev Commenting on closed PR is unlikely to be seen. This should probably be a separate issue instead