Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force alpha to 1 in tonemap pass in RD renderers #84684

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Nov 9, 2023

Fixes: #83131 for X11
Fixes: #61969

Also only clear to alpha 0 when using transparent background

This change isn't needed in the compatibility renderer as it already correctly checks for transparent_bg when setting the clear color and it avoids writing to alpha when not needed.

Setting to draft for now as I have only tested with the MRPs from the two projects. Its possible that other effects rely on this previous erroneous behaviour. So we need to test carefully.

Also only clear to alpha 0 when using transparent background
@akien-mga
Copy link
Member

I confirm that this fixes both linked bug reports for me on Linux X11.

Tested with these three Vulkan devices, both Mobile and Forward+:

Vulkan API 1.3.246 - Forward+ - Using Vulkan Device #0: Intel - Intel(R) HD Graphics 630 (KBL GT2)
Vulkan API 1.3.246 - Forward+ - Using Vulkan Device #0: AMD - AMD Radeon RX Vega M GL Graphics (RADV VEGAM)
Vulkan API 1.3.246 - Forward+ - Using Vulkan Device #0: Unknown - llvmpipe (LLVM 15.0.6, 256 bits)

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Nov 10, 2023
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Nov 14, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@clayjohn clayjohn modified the milestones: 4.3, 4.4 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants