Increase precision of RAW mode in ColorPicker #83851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the slider step to `0.001` but keeps SpinBox arrow increments at `0.01`.
fire
approved these changes
Oct 23, 2023
|
Just as I imagined it 👍 |
aXu-AP
reviewed
Oct 23, 2023
| @@ -43,6 +43,7 @@ class ColorMode { | |||
|
|
|||
| virtual int get_slider_count() const { return 3; }; | |||
| virtual float get_slider_step() const = 0; | |||
| virtual float get_spinbox_arrow_step() const { return get_slider_step(); }; | |||
There was a problem hiding this comment.
I was thinking it should have a default value so that individual color modes aren't required to implement this method.
There was a problem hiding this comment.
0 is the default value for SpinBox.custom_arrow_step, it will be ignored. From docs:
float custom_arrow_step = 0.0
If not 0, value will always be rounded to a multiple of custom_arrow_step when interacting with the arrow buttons of the SpinBox.
But defining it explicitly doesn't hurt either, I'm happy either way 🙂
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the slider step to
0.001but keeps SpinBox arrow increments at0.01.Thanks @aXu-AP for the suggested fix 🙂
Preview
simplescreenrecorder-2023-10-23_18.32.31.mp4