Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some Editor, OpenXR, VideoStream code #83683

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Clean up some Editor, OpenXR, VideoStream code #83683

merged 1 commit into from
Oct 20, 2023

Conversation

YuriSizov
Copy link
Contributor

While investigating some issues I noticed a few things that could be cleaned up, but don't fit any particular PR I can make right now. So I made this.

  • EditorNode has excessive and pointless checks for Input singleton (we already access it without a check prior to this, and then we also check for it twice for some reason).
  • EditorNode initialization order is a bit awkward (grouped server configuration a bit better, moved some instructions in a more sensible order).
  • OpenXR binds a method that doesn't need that (used only for call_deferred, which doesn't need it with Callable).
  • VideoStream has a formatting error (surprised it's not caught by clang format).

@YuriSizov
Clean up some Editor, OpenXR, VideoStream code
cd31407 
- EditorNode has excessive and pointless checks for Input singleton.
- EditorNode initialization order is a bit awkward.
- OpenXR binds a method that doesn't need that (for call deferred).
- VideoStream has a formatting error.
@YuriSizov YuriSizov added this to the 4.2 milestone Oct 20, 2023
@YuriSizov YuriSizov requested a review from akien-mga October 20, 2023 15:57
akien-mga
akien-mga approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

AThousandShips
AThousandShips approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 46efe48 into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the random-cleanup branch October 20, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@YuriSizov @akien-mga @AThousandShips