Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement #82866

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Add docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement #82866

merged 1 commit into from
Nov 11, 2023

Conversation

Anutrix
Copy link
Contributor

@Anutrix Anutrix commented Oct 5, 2023

Added docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement.

The changes in xr_server.cpp is made to match text_server.cpp which improves readability of the interface name.

XR: Removed interfaceNative mobile
XR: Removed interfaceOpenXR

is changed to:

XR: Removed interface "Native mobile"
XR: Removed interface "OpenXR"

@Anutrix Anutrix requested review from a team as code owners October 5, 2023 16:51
@Calinou Calinou added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 5, 2023
@Calinou Calinou added this to the 4.2 milestone Oct 5, 2023
@Anutrix Anutrix force-pushed the minor-fixes-2023 branch 2 times, most recently from 73b5109 to c2c5cd5 Compare October 5, 2023 18:54
@Anutrix
Copy link
Contributor Author

Anutrix commented Oct 6, 2023

I've made the changes. Do let me know if anything else is needed.

@Anutrix Anutrix requested a review from Calinou October 10, 2023 07:39
@YuriSizov
Copy link
Contributor

@QbieShay Would you mind validating these descriptions?

AThousandShips
AThousandShips reviewed Nov 11, 2023
View reviewed changes
doc/classes/CPUParticles2D.xml Outdated Show resolved Hide resolved
doc/classes/CPUParticles2D.xml Outdated Show resolved Hide resolved
doc/classes/GPUParticles2D.xml Outdated Show resolved Hide resolved
doc/classes/GPUParticles2D.xml Outdated Show resolved Hide resolved
@AThousandShips
Copy link
Member

AThousandShips commented Nov 11, 2023 •
edited
Loading

Please rebase your branch, there might be some issue with out of date references with the codespell package (over a month out of date branch)

@Anutrix
Copy link
Contributor Author

Anutrix commented Nov 11, 2023

Please rebase your branch, there might be some issue with out of date references with the codespell package (over a month out of date branch)

Done.

@akien-mga akien-mga merged commit 0625f06 into godotengine:master Nov 11, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov changed the title Added docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement Add docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement Jan 23, 2024
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@AThousandShips AThousandShips AThousandShips approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@Anutrix @YuriSizov @AThousandShips @akien-mga @Calinou