-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added remaining animation-related class reference docs #82713
Conversation
<member name="_data" type="Dictionary" setter="_set_data" getter="_get_data" default="{}"> | ||
Contains a [Dictionary] of [Animation] resources. | ||
</member> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a bug that a member starting with an underscore is exposed.
Sounds like this was just meant to serialization, not public access?
CC @godotengine/animation
But well now that it's been exposed I'm not sure we can take it back without breaking compat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be fine. It needs to have its usage changed to PROPERTY_USAGE_NO_EDITOR | PROPERTY_USAGE_INTERNAL
. If it needs to be exposed, it needs to be renamed anyway. So we'd be breaking compatibility.
If we do neither, we risk it being accidentally unexposed if we, say, fix the fact that an underscored member is added to the docs (it should be stripped from XMLs by the doctool, the fact that it's not is a bug).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made #84376
Superseded by #84376. Thanks for your contribution nevertheless! |
Oh wait, this also added a description to |
Sure |
Added remaining animation-related class reference docs.