Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editor support --fullscreen command-line argument #81608

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Make editor support --fullscreen command-line argument #81608

merged 1 commit into from
Sep 26, 2023

Conversation

timothyqiu
Copy link
Member

  • Project Manager already supports --fullscreen. But the window was created as windowed first. This PR makes the window fullscreen directly.
  • Editor did not take --fullscreen into account. This PR adds the support.

@timothyqiu timothyqiu added this to the 4.2 milestone Sep 13, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner September 13, 2023 08:27
@akien-mga akien-mga requested a review from bruvzg September 13, 2023 12:07
@JadeWhite
Copy link

Awesome and elegant

@akien-mga akien-mga merged commit cdbc2fd into godotengine:master Sep 26, 2023
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the fullscreen-editor branch September 26, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
enhancement topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @JadeWhite @akien-mga