Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate error correctly when max texture size for lightmaps is too small. #81543

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

DarioSamo
Copy link
Contributor

Add error handling for BAKE_ERROR_LIGHTMAP_TOO_SMALL, which was previously ignored. Fixes #81453.

…small.

Add error handling for BAKE_ERROR_LIGHTMAP_TOO_SMALL, which was previously ignored. Fixes godotengine#81453.
@DarioSamo DarioSamo requested review from a team as code owners September 11, 2023 12:17
@akien-mga akien-mga added bug topic:3d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 11, 2023
@akien-mga akien-mga added this to the 4.2 milestone Sep 11, 2023
@akien-mga akien-mga merged commit 7471ac2 into godotengine:master Sep 12, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightmap baking crashes if the size required by the mesh is bigger than the size allowed by LightmapGI.
4 participants