Fix int to uint implicit cast error when use mat3 uniform in compatibility renderer #81494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
force-pushed
the
Fix-int-to-uint-implicit-cast-error-when-use-uniform-mat3-in-gles3
branch
from
62b8a86 to
1d4e5a7
Compare
akien-mga
reviewed
Sep 10, 2023
jsjtxietian
force-pushed
the
Fix-int-to-uint-implicit-cast-error-when-use-uniform-mat3-in-gles3
branch
from
1d4e5a7 to
9376a13
Compare
clayjohn
reviewed
Oct 26, 2023
jsjtxietian
force-pushed
the
Fix-int-to-uint-implicit-cast-error-when-use-uniform-mat3-in-gles3
branch
from
9376a13 to
967e0e6
Compare
clayjohn
approved these changes
Oct 31, 2023
clayjohn
added
the
cherrypick:4.1
|
Thanks! |
jsjtxietian
deleted the
Fix-int-to-uint-implicit-cast-error-when-use-uniform-mat3-in-gles3
branch
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #81473
In
_get_global_shader_uniform_from_type_and_index, we should use unit to do the math when the uniform is an index to the global table.But this commit might have other implications, feel free to correct me !