Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary validity checks from Button and TextureRect #81383

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Remove unnecessary validity checks from Button and TextureRect #81383

merged 1 commit into from
Sep 7, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 6, 2023 •
edited
Loading

The one in TextureRect appears to be a leftover from earlier code, and the one in Button was copied from there.

Doing some deep digging this seems to be some code from back when Texture had add_change_receptor, and derives from Sprite, being copied over to TextureRect

@AThousandShips
Remove unnecessary validity checks from Button and TextureRect
380db4d 
The one in `TextureRect` appears to be a leftover from earlier code, and
the one in `Button` was copied from there.
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 6, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 6, 2023 14:46
@akien-mga akien-mga merged commit 4bf3de7 into godotengine:master Sep 7, 2023
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the valid_remove branch September 7, 2023 12:42
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @akien-mga @KoBeWi