Fix example for Object._set documentation
#80475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe showing a real example of a fake property that actually does something useful would be good indeed. |
KoBeWi
force-pushed
the
that's_not_how_you_do_set
branch
from
26ebb76 to
9848027
Compare
akien-mga
reviewed
Aug 10, 2023
KoBeWi
force-pushed
the
that's_not_how_you_do_set
branch
from
9848027 to
3ff25cc
Compare
akien-mga
reviewed
Aug 10, 2023
KoBeWi
force-pushed
the
that's_not_how_you_do_set
branch
2 times, most recently
from
a496b85 to
80904f9
Compare
raulsntos
reviewed
Aug 10, 2023
|
If we add a more practical example, prints are probably not needed anymore. Can be kept as code comments instead (i.e. replace prints with |
KoBeWi
force-pushed
the
that's_not_how_you_do_set
branch
from
80904f9 to
90160ef
Compare
YuriSizov
approved these changes
Aug 24, 2023
raulsntos
approved these changes
Aug 24, 2023
|
Thanks! |
YuriSizov
added
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is supposed to return
trueif the property was set (interestingly the C# example is correct).Though I wonder if the example shouldn't be improved; it's technically incomplete, because a user might not know what to put instead of print.