Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make POT generator able to extract strings from binary operations #79998

Closed
wants to merge 1 commit into from
Closed

Make POT generator able to extract strings from binary operations #79998

wants to merge 1 commit into from

Conversation

YeldhamDev
Copy link
Member

Now strings can be extract from binary operations inside GDScript, such as:

tr("string 1" + "string 2")

@YeldhamDev YeldhamDev added this to the 4.2 milestone Jul 28, 2023
@YeldhamDev YeldhamDev requested a review from a team as a code owner July 28, 2023 21:39
@dalexeev
Copy link
Member

Since tr() is runtime and not a macro, I think we could add any constant expressions of the tr() argument to localization keys, not just when it's a concatenation of string literals. Plus it's easier to implement.

@YeldhamDev
Copy link
Member Author

@dalexeev This is my first time messing around with anything related to the GDScript parser, so I don't know how I would handle that.

@dalexeev dalexeev mentioned this pull request Jul 29, 2023
Merged
@dalexeev
Copy link
Member

@YeldhamDev I opened an alternative PR #80020.

@adamscott
Copy link
Member

Nice translation branch, @YeldhamDev. I approved @dalexeev's PR, but thanks for your PR!

@YuriSizov
Copy link
Contributor

Superseded by #80020.

@YuriSizov YuriSizov closed this Aug 1, 2023
@YuriSizov YuriSizov removed this from the 4.2 milestone Aug 1, 2023
@YeldhamDev YeldhamDev deleted the 01110100_01110010_01100001_01101110_01110011_01101100_01100001_01110100_01101001_01101111_01101110 branch August 1, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived enhancement topic:editor topic:gdscript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YeldhamDev @dalexeev @adamscott @YuriSizov