Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Only cache objects that are part of the current build #79995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RedworkDE
Copy link
Member

This is the first idea from #79919 (comment)
This prevents caches from growing any larger than absolutely necessary to get effectively incremental builds in the CI, but makes selection of which cache to fetch significantly more important as the cache no longer contains any objects from previous (or potentially unrelated) builds.

Currently disabled on windows as the find command is an entirely different tool there and those builds don't have space issues rn, so I didn't go looking for how to best do this on windows for this PR. (But if desired the best way would probably to rewrite this is JS, which would also eliminated the dependency for running stuff in the post step)

@RedworkDE RedworkDE added this to the 4.x milestone Jul 28, 2023
@RedworkDE RedworkDE requested a review from YuriSizov July 28, 2023 18:38
@RedworkDE RedworkDE requested a review from a team as a code owner July 28, 2023 18:38
@YuriSizov
Copy link
Contributor

I think this is rather hacky. The idea is solid, we should try to reduce the size of the cache by cutting the excess. But this doesn't seem robust to me. Maybe we shouldn't cache .scons-cache and should do something else instead.

@YuriSizov YuriSizov removed their request for review August 2, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants