Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Linux: Fix udev fallback logic with use_sowrap=no #79111

Merged

Conversation

akien-mga
Copy link
Member

Partial backport of #79097 to 4.0 to fix a bug introduced by the cherry-pick of #76961.

@akien-mga akien-mga added this to the 4.0 milestone Jul 6, 2023
@akien-mga akien-mga requested a review from a team as a code owner July 6, 2023 15:12
@akien-mga akien-mga changed the title Linux: Fix udev fallback logic with use_sowrap=no [4.0] Linux: Fix udev fallback logic with use_sowrap=no Jul 6, 2023
int dylibloader_verbose = 1;
#else
int dylibloader_verbose = 0;
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a // DEBUG_ENABLED?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be, but I mostly use it where there's ambiguity. Here it didn't seem too necessary.

@akien-mga akien-mga merged commit 31b1f98 into godotengine:4.0 Jul 11, 2023
@akien-mga akien-mga deleted the 4.0-fix-udev-fallback-with-use_sowrap-no branch July 11, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants