Add static check for overzealous .gitignores and fix an example of such. #78908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 29, 2023
akien-mga
added
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.3. (Only the first commit, not the added CI check as there's still an issue with it #81151.) |
akien-mga
removed
the
cherrypick:3.5
|
Cherry-picked for 4.1.4. Also just the first commit for the same reason. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #47212.
As part of my project setup, I decompress Godot into its own directory and copy the source across. This is kind of awkward to work with because Godot frequently has parts of its own repository ignored. I've got my scripts hooked up to work around this, but it keeps happening and I really think there should be a static check to solve it.
Enclosed is that static check, along with a fix for the latest example of the problem. If you'd like to see what the error looks like, check out https://github.com/zorbathut/godot/actions/runs/5431343555/jobs/9877648317 which was an intentional failure for testing - note that it also prints the file the ignore comes from. Github lists this process as taking zero seconds; in local testing, it's about 0.04 seconds.
I also tweaked a .gitignore to unignore a directory, though I'm not sure if that was the right solution.
I'm happy to make adjustments!