Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting release Android builds without a debug keystore #78123

Conversation

YeldhamDev
Copy link
Member

This PR adds an extra argument (p_debug, defaulted to false) in the can_export() and has_valid_export_configuration() functions to allow exporters to know if debug mode is enabled.

Fixes #45766.

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Added a minor comment to address.

editor/export/editor_export_platform.cpp Show resolved Hide resolved
@YeldhamDev YeldhamDev force-pushed the if_you_want_anything_done,_do_it_yourself branch from 95eab1c to 41a75cf Compare June 19, 2023 04:02
@akien-mga akien-mga merged commit eb9c96b into godotengine:master Jun 19, 2023
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the if_you_want_anything_done,_do_it_yourself branch June 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug keystore required even for release exports on Android
3 participants