Reimplement support for bicubic sampling in LightmapGI #77912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings it to feature parity with 3.x's lightmapping implementation. Only supported in Forward+, not Forward Mobile as the push constant for instances is already full (128 bytes). TODO: - Make it work correctly. - Add a project setting to disable bicubic sampling for low-end systems.
9 tasks
2 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it to feature parity with 3.x's lightmapping implementation.
Only supported in Forward+, not Forward Mobile as the push constant for instances is already full (128 bytes).
I won't have much time to work on this, so please look into continuing this in your own branch if possible. I don't even know if the way of passing the lightmap texture size is correct – as I understand it, it needs to be per-instance as multiple LightmapGIs can be used in the same scene at the same time.
3.xused a uniform here, but we don't seem to use uniforms anymore in the 4.x scene shader.3.x) #49935. See also LightmapGI: Implement shadowmask for DirectionalLight #77284, which benefits from bicubic sampling.TODO