Update extension API validation #77445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that multiple changes to one method cannot hide each other in the CI. - Check virtual methods for changes. - Compare the detailed changes to a method. - Compare enums. - Fix comparing global enums. - Use `vformat` to build error messages.
|
I didn't test this, but skimming the code and looking at the changes to the .expected file, this looks awesome! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #76647 (comment), originally just trying to ensure that ignoring the hash change of one method does not hide any future changes to that method, but has somewhat grown in scope to tracking all changes that possibly interfere with compatibility, not just those that break gdextension binary compatibility.
Check
misc/extension_api_validation/4.0-stable.expectedfor how the new errors look like currently.Basically the only changes to existing APIs that it now doesn't try to complain about are changing parameter names and increasing the value of an enums
_MAXvalue.