Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GLTFSkin binding for the godot_skin property #77413

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix GLTFSkin binding for the godot_skin property #77413

merged 1 commit into from
May 24, 2023

Conversation

theraot
Copy link
Contributor

@theraot theraot commented May 23, 2023 •
edited
Loading

Fixes #77405

Tested:
image

Also tested that reading and writing a GLTF with a rigged model still works. Not depicted.

@theraot theraot requested a review from a team as a code owner May 23, 2023 21:45
fire
fire approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronfranke This looks fine?

fire
fire requested changes May 24, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be using the resource property hint

@akien-mga akien-mga changed the title Fix GLTFSkin binding for the godot_sking property Fix GLTFSkin binding for the godot_skin property May 24, 2023
@akien-mga akien-mga added this to the 4.1 milestone May 24, 2023
@akien-mga akien-mga merged commit dc625bc into godotengine:master May 24, 2023
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Fix GLTFSkin binding for the godot_skin property Fix GLTFSkin binding for the godot_skin property Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:import
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

GLTFSkin does not report the class_name of the godot_skin property.
4 participants
@theraot @akien-mga @fire @aaronfranke