-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for ButtonGroups to be unpressed #76279
Merged
akien-mga
merged 1 commit into
godotengine:master
from
TheSecondReal0:buttongroup-unpress
Apr 24, 2023
Merged
Add an option for ButtonGroups to be unpressed #76279
akien-mga
merged 1 commit into
godotengine:master
from
TheSecondReal0:buttongroup-unpress
Apr 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSecondReal0
force-pushed
the
buttongroup-unpress
branch
3 times, most recently
from
April 20, 2023 05:44
77c787d
to
9ec7342
Compare
KoBeWi
reviewed
Apr 20, 2023
KoBeWi
reviewed
Apr 20, 2023
Chaosus
reviewed
Apr 20, 2023
Chaosus
reviewed
Apr 20, 2023
Chaosus
reviewed
Apr 20, 2023
Chaosus
reviewed
Apr 20, 2023
KoBeWi
approved these changes
Apr 20, 2023
@TheSecondReal0 A single commit is preferred, please squash the commits (see the docs for how to rebase). |
TheSecondReal0
force-pushed
the
buttongroup-unpress
branch
from
April 20, 2023 22:09
74bdd72
to
c6f0056
Compare
kleonc
reviewed
Apr 20, 2023
Add an option for ButtonGroups to be unpressed Apply suggestions from code review Co-Authored-By: Tomek <[email protected]> Co-Authored-By: Yuri Rubinsky <[email protected]> Co-Authored-By: kleonc <[email protected]>
TheSecondReal0
force-pushed
the
buttongroup-unpress
branch
from
April 20, 2023 23:10
8c317fc
to
d829b43
Compare
akien-mga
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#6722