Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux/BSD] Add dynamically loaded library version checks. #74978

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 16, 2023

Adds min. version checks (or function availability checks in case there's no API to check version) for the dynamically loaded libraries.

Splits XKBcommon function checks in two (for version 0.5 and 0.8) to support dead key composition on older distros (0.8 is required to decode Unicode key labels only).

Most of the min. versions correspond to Ubuntu 16.04 (the oldest distro on which I was able to build and test Godot 4).

Copy link
Contributor

@Riteo Riteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you're checking for every library's major version as more-than-or-equal a target value. Major version bumps usually mean breaking changes. Are you sure that's a good idea?

@bruvzg
Copy link
Member Author

bruvzg commented Mar 17, 2023

Major version bumps usually mean breaking changes. Are you sure that's a good idea?

If it's a backward incompatible change, soname should also change, so it won't load the library at all.

@Riteo
Copy link
Contributor

Riteo commented Mar 17, 2023

@bruvzg

If it's a backward incompatible change, soname should also change, so it won't load the library at all.

Right, all right then.

@bruvzg bruvzg force-pushed the linux_version_check branch from 1a2e0e9 to bed46f7 Compare March 20, 2023 06:13
@bruvzg bruvzg marked this pull request as ready for review March 20, 2023 06:35
@bruvzg bruvzg requested review from a team as code owners March 20, 2023 06:35
@akien-mga akien-mga modified the milestones: 4.x, 4.1 Apr 18, 2023
@akien-mga akien-mga merged commit 63d17df into godotengine:master Apr 18, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants