Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken shortcut key input #74535

Merged

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Mar 7, 2023

Previously, shortcut key input could be broken after switching input methods and typing.

Fix #74181.

@Rindbee Rindbee requested a review from a team as a code owner March 7, 2023 08:40
@Rindbee
Copy link
Contributor Author

Rindbee commented Mar 7, 2023

After selecting one of the spelling results, an InputEventKey with pressed=false corresponding to the key used to select the result will be generated. Should I ignore this release action?

@akien-mga akien-mga merged commit 013a457 into godotengine:master Mar 7, 2023
@akien-mga
Copy link
Member

Thanks!

@Rindbee Rindbee deleted the fix-broken-shortcut-key-input branch March 7, 2023 14:25
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shortcuts in code editor stop working (saving with CTRL+S, script navigation with ALT+ARROW)
4 participants