[Windows] Improve non-exclusive full-screen mode. #72787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Video driver timeout after pressing
gl_compatibility On Forward+ there's no crash, but I get black flashes |
|
On a laptop with Win10 21H2 and Intel HD Graphics 620, the border is gone but I get the described black flashes when opening menus. |
|
Tested with integrated AMD Ryzen graphics, and it doesn't work (unlike on NVIDIA, menus are usable, but cause black flashes). So I guess adding border (or changing client area to not match screen size in some other way) is still the only way to prevent exclusive full-screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes single pixel border in the non-exclusive full-screen mode.
Fixes #63500
Note: needs testing on a different GPUs to make sure it's not triggering exclusive full-screen, I have tested it on NVIDIA only. Testing on AMD and Intel is highly appreciated. The easiest way to test it is to use Shift+F11 combination in the editor and checking if menus are working fine, without blinking/fading to black (editor should be in multi window mode).