-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some small bugs in the Window
node
#71470
Conversation
I guess this breaks this again, so this PR needs to add a way to have a debounced call to |
@YuriSizov The correct way to update that would be with |
@YeldhamDev I'm not sure if this would cover all the cases with windows and derivatives. Namely, this won't update a detached window. It doesn't matter for the title color, but styleboxes can affect the size of it still, which needs recomputing. A delay is likely needed either way, because the values can change very quickly from the inspector. |
Altering theme properties of |
A repro would be appreciated. It used to work in December, when my PR was made. I'm not aware of any regressions since. |
Just create a |
Its properties are related to the list of files, which doesn't get regenerated on theme changes. I think it's a specific issue with that node. You can see it gets updated on scene save, probably because the list is reconstructed then.
|
80ba398
to
5bb165f
Compare
5bb165f
to
8046186
Compare
8046186
to
52b077c
Compare
@YuriSizov Alright, made some changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like there are any regressions now. The rest of the changes look sensible too.
(Tested with PR artifacts)
Thanks! |
Madechild_controls_changed()
check ifwrap_controls
is enabled within itself. Avoiding unnecessary window updates, such as the one in Unintended window size changes (DisplayServer regression) #58032.child_controls_changed()
trigger only ifwrap_controls
is enabled when caused by a translation update. See Unintended window size changes (DisplayServer regression) #58032 (comment).wrap_controls
is enabled.