Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pingpong-loop with loop_wrap is not working & clean-up cubic interpolation key retrieve process #70547

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Dec 25, 2022

Follow up #63602.

The same fixes as in #58344 needed to be applied to pingpong-loop.

Before:

Godot.2023.01.04.-.23.16.49.03.mp4

After fix:

Godot.2023.01.04.-.23.16.49.03.mp4

@TokageItLab TokageItLab added this to the 4.0 milestone Dec 25, 2022
@TokageItLab TokageItLab requested review from a team and fire December 25, 2022 03:54
@TokageItLab TokageItLab changed the title Fix pingpong with loop wrap is not working and cleanup cubic interpolation key retrieve process Fix pingpong-loop with loop_wrap is not working & clean-up cubic interpolation key retrieve process Dec 25, 2022
@TokageItLab TokageItLab marked this pull request as draft December 25, 2022 04:14
@TokageItLab TokageItLab force-pushed the pingpong-wrap branch 2 times, most recently from 8fad97f to bbf8c2d Compare December 25, 2022 05:03
@TokageItLab TokageItLab marked this pull request as ready for review December 25, 2022 05:03
@TokageItLab TokageItLab requested review from a team as code owners December 25, 2022 05:03
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked the math.

The code seems to be working. There is video proof.

@akien-mga akien-mga merged commit e5f6e03 into godotengine:master Jan 5, 2023
@akien-mga
Copy link
Member

Thanks!

@TokageItLab TokageItLab deleted the pingpong-wrap branch February 14, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants