Ensure depth buffer format picked actually supports full intended usage #70300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Dec 19, 2022
|
This wouldn't happen to solve #67430 (comment) by any chance? |
|
I don't think it will, but the needed fix may be similar to this patch. |
clayjohn
approved these changes
Dec 19, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is needed in such an exhaustive fashion, since. for instance, in D3D12
DATA_FORMAT_D24_UNORM_S8_UINTis usable for a depth buffer (obvious) but can't be sampled and assuming the former implies the latter causes an error when trying to create the texture.